refactor: migrate grid and spacing utilities to PostCSS loops #283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated NX build cache timestamps and hashes for @go-ui/vue and @go-ui/core builds - Updated workspace data files including process ID and file map entries - Simplified file map by removing unused project references
- Add postcss-for, postcss-each, postcss-simple-vars plugins - Convert spacing.css to use PostCSS loops and variables - Convert grid.css to use PostCSS loops and variables - Update stencil.config.ts with new PostCSS plugins - Update package.json with new dependencies - Add .nx cache files to .gitignore
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #278
Changes Made
Added new PostCSS plugins:
postcss-for- For@forloop supportpostcss-each- For@eachloop supportpostcss-simple-vars- For CSS variablesConverted static utility classes to use loops:
spacing.css: Reduced from 620 to 48 linesgrid.css: Reduced from 203 to 145 linesAdded
.nxcache files to .gitignoreUpdated dependencies in package.json and pnpm-lock.yaml
Updated stencil.config.ts with new PostCSS plugins
Benefits
Testing
Documentation
Added two new Markdown files:
COMPLETION_SUMMARY.md- Details of changes madeLOOP_BASED_APPROACH.md- Documentation of the new loop-based approach