feat: add AWS_S3_FORCE_PATH_STYLE environment variable support
#122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Summary Adds support for the `AWS_S3_FORCE_PATH_STYLE` environment variable to enable path-style addressing for S3-compatible services. ## Changes - Modified `s3_client()` function to check for `AWS_S3_FORCE_PATH_STYLE` environment variable - When set to "true", configures the S3 client with `force_path_style(true)` - Added `Config` import from `aws_sdk_s3` ## Why This enables Convex to work with S3-compatible services like MinIO, LocalStack, and other object storage providers that require path-style addressing (`https://s3.amazonaws.com/bucket/key` instead of `https://bucket.s3.amazonaws.com/key`). ## Testing - [ ] Existing S3 functionality remains unchanged when environment variable is not set - [ ] Path-style addressing works when `AWS_S3_FORCE_PATH_STYLE=true` is set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for the
AWS_S3_FORCE_PATH_STYLEenvironment variable to enable path-style addressing for S3-compatible services.Changes
s3_client()function to check forAWS_S3_FORCE_PATH_STYLEenvironment variableforce_path_style(true)Configimport fromaws_sdk_s3Why
This enables Convex to work with S3-compatible services like MinIO, LocalStack, and other object storage providers that require path-style addressing (
https://s3.amazonaws.com/bucket/keyinstead ofhttps://bucket.s3.amazonaws.com/key).By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.