Skip to content

Use .__str__ rather than .message to print errors. #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use .__str__ rather than .message to print errors. #24

wants to merge 1 commit into from

Conversation

@jorgenpt
Copy link

@jorgenpt jorgenpt commented May 5, 2015

This helps because IOError does not assign `message', but str prints
both the path and the error that occurred.

Old behavior:

$ bin/1pass foo
1pass: Error:

New behavior:

$ bin/1pass foo               
1pass: Error: [Errno 2] No such file or directory: '/home/jorgen/Dropbox/1Password.agilekeychain/data/default/encryptionKeys.js'

@jorgenpt
Use .__str__ rather than .message to print errors.
49d7d8b 
This helps because IOError does not assign `message', but __str__ prints
both the path and the error that occurred.

This should address georgebrock#7.
@jorgenpt jorgenpt force-pushed the better-error-messages branch from 621f56e to 49d7d8b Compare May 5, 2015 23:25
@jorgenpt
Copy link
Author

jorgenpt commented May 5, 2015

Fixes issue #7.

@AlJohri
Copy link

AlJohri commented Jun 17, 2017

@AdamIsrael LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jorgenpt @AlJohri