Fallback improvements #48
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiimjasmine00
changed the title
hiimjasmine00
changed the title
hiimjasmine00
changed the title
matcool
reviewed
Oct 23, 2025
Comment on lines
-37
to
+66
| CCSprite* sprite = CCSprite::create("fallback.png"_spr); | ||
| CCSprite* sprite = CCSprite::createWithSpriteFrame(spriteFrame); |
Contributor
Author
There was a problem hiding this comment.
The CCSpriteFrameCache::spriteFrameByName hook will take care of that
Member
There was a problem hiding this comment.
hm ok, maybe add a comment like // this will be handled by our hook
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of one unified fallback texture, there's one for every time you screw up.
Also, they have names attached to them, so you know exactly how you screwed up.