Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions gxcloudstorage-googlecloudstorage/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
<dependency>
<groupId>com.google.cloud</groupId>
<artifactId>google-cloud-storage</artifactId>
<version>1.118.1</version>
<version>2.58.1</version>
<exclusions>
<exclusion>
<groupId>com.google.code.findbugs</groupId>
Expand Down Expand Up @@ -67,15 +67,17 @@
<groupId>com.google.api.grpc</groupId>
<artifactId>proto-google-iam-v1</artifactId>
</exclusion>
<exclusion>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it okay to remove this exclusion?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I did it in a second commit because it failed the test execution. It was looking for a protbuf class in runtime.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But for some reason that dependency had been excluded... I don't think it's good to add it just like that without being clear about why you need it now and before your change you didn't.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original library (v1.118.1) was made on August 2021, we are updating it to the latest from october 2025.
When we added it it didn't use anything from protobuf for the functions we use in GX, therefore someone exclude it, samewere in 4 years they made changes there and now they use a class from protobuf to a function we need on GX since it failed on the tests. What? Why? I don't know, it's a transitive reference, tests failed with the message that it couldn't find some protbuf class executing on github. We could try to exclude it again but the test will fail again.

<groupId>com.google.protobuf</groupId>
<artifactId>protobuf-java</artifactId>
</exclusion>
<exclusion>
<groupId>com.google.protobuf</groupId>
<artifactId>protobuf-java-util</artifactId>
</exclusion>
</exclusions>
</dependency>
<!-- overwrite grpc-netty-shaded from google-cloud-storage because of CVEs-->
<dependency>
<groupId>io.grpc</groupId>
<artifactId>grpc-netty-shaded</artifactId>
<version>1.75.0</version>
</dependency>
</dependencies>
</project>
Loading