-
Notifications
You must be signed in to change notification settings - Fork 12
Unify file download logic to set a configurable User-Agent #1196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
claudiamurialdo
wants to merge
4
commits into
master
Choose a base branch
from
fix/http-client-user-agent
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The User-Agent is now consistently applied using the GX_HTTPCLIENT_USER_AGENT environment variable or HTTPCLIENT_USER_AGENT in appsettings.json Affects the following functionalities: Adding an image to a PDF ImageAPI when handling images from a URL Inserting an image from url in the database (GetBinary in GxDataRecord)
Cherry pick to beta success |
Cherry pick to beta success |
fedeazzato
previously approved these changes
Oct 2, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
Cherry pick to beta success |
fedeazzato
previously approved these changes
Oct 8, 2025
…ncy with the property name
Cherry pick to beta success |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The User-Agent is now consistently applied using the GX_UserAgentHeader environment variable or UserAgentHeader in appsettings.json.
Affects the following functionalities:
Issue:206488