do not "set arm show-opcode-bytes" when not necessary #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… undefined command and break
gdbinit
added a commit
that referenced
this pull request
Mar 25, 2014
do not "set arm show-opcode-bytes" when not necessary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the ARMv7 boxes of http://ioarm.smashthestack.org/ "set arm show-opcode-bytes" is an undefined command, therefore when called in hook-stop it breaks hard and context cannot be displayed properly.
$ uname -a
Linux arm1 3.8.13.13-30068-g2296bce #12 SMP PREEMPT Mon Feb 3 15:50:09 CET 2014 armv7l armv7l armv7l GNU/Linux
$ gdb
GNU gdb (GDB) 7.5.91.20130417-cvs-ubuntu
This GDB was configured as "arm-linux-gnueabihf".
(gdb) set arm show-opcode-bytes 0
Undefined set arm command: "show-opcode-bytes 0". Try "help set arm".
It would be nice if we could test if the command exists before using it but I don't know a way.
In the meantime I suggest to simply not set it when $ARMOPCODES is not 1.
As a result hook-stop doesn't break and context works.