Fix double minor version additions in update images GHA #1396
+35
−20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The resulting PR shows
targetVersion: '>= 1.34'
includestag: v1.34.0
.The
release notes
show:v1.34.0
should not be inimages.yaml
, it's better not to mention it as a minor update, so the code is changed in order to not print the 1st line in such a case. For consistency reasons (and since it makes more sense), the same style is applied to patch updates, so intermediate updates that do not end up in theimages.yaml
are not mentioned anymore.Release note: