-
Notifications
You must be signed in to change notification settings - Fork 37
GHA release workflow supports multiple tags via github-tag-templates
input field
#1382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GHA release workflow supports multiple tags via github-tag-templates
input field
#1382
Conversation
@TuanAnh17N, @ccwienk, @zkdev, @8R0WNI3 You have pull request review open invite, please check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
generally-speaking, it is a reasonable ask to allow creation of multiple tags (thanks for taking the time to raise a pullrequest, rather than just a feature-request :-)).
However, I would prefer this change to focus on the actual feature (one tag -> list of (extra-)tags). Refactoring and adding of validation code may also be adequate. However, I would prefer such changes to be done in separate commits.
Also, with such increased amount of code, I would prefer to mv majority of code into a separate script (any file within an action's directory is available at ${{ github.action_path }}
).
@shreyas-s-rao You need rebase this pull request with latest master branch. Please check. |
604a9ef
to
e9f4649
Compare
@ccwienk thanks for your suggestions. I have now added a new field |
GHA release workflow supports multiple tags via
github-tag-templates
input field. I have replaced the previousgithub-tag-template
field withgithub-tag-templates
, since I nobody is usinggithub-tag-template
in gardener org yet, and I wanted to avoid the complexity of handling the same input from multiple input fields and deprecation overhead.Also, this field is technically a string (comma-separated values validated in
release/action.yaml
), since the schema does not allowarray
orlist
type in reusable workflows - ref discussion.I also split
push release-tag
step in release action intopush tag-refs
andpush release-commit
for clear separation of responsibilities.Please let me know if the approach is correct. Also, majority of the changes are AI generated, so please let me know if there's anything I need to correct here as well.
Fixes #1381
Release note: