Skip to content

Conversation

zkdev
Copy link
Member

@zkdev zkdev commented Feb 27, 2025

Google Artifact Registry has a built-in mechanism.

Release note:

OCM clean-up logic (based on version-policies) is removed (we use oci-registry built-ins instead).

Google Artifact Registry has a built-in mechanism.
@gardener-robot gardener-robot added needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Feb 27, 2025
@zkdev zkdev requested a review from AndreasBurger February 27, 2025 09:07
Copy link
Member

@ccwienk ccwienk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removing this seems like a good idea. however, there are quite a few pipelines that configured this explicitly. I suggest to remove existing configurations prior to dropping this codepath

@gardener-robot gardener-robot added the needs/changes Needs (more) changes label Feb 27, 2025
@zkdev
Copy link
Member Author

zkdev commented Feb 27, 2025

@ccwienk
I kept the attribute spec exactly due to this, so we can clean up afterwards.

@ccwienk
Copy link
Member

ccwienk commented Feb 27, 2025

@zkdev : I understood that. Still, I do not think we should just silently change pipeline-contract w/o rolling this out explicitly (there might be pipelines that actually rely on this cleanup-code).

@gardener-robot
Copy link

@TuanAnh17N, @8R0WNI3, @AndreasBurger You have pull request review open invite, please check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs/changes Needs (more) changes needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants