Skip to content

Update interactive tool command to reflect new package namespace #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2025

Conversation

dometto
Copy link
Contributor

@dometto dometto commented Apr 8, 2025

Recently, the gx-it-proxy npm package has been moved to the @galaxyproject namespace, where v.0.2.2 is now published.

However, Gravity still is configured to run npx install gx-it-proxy instead of npx install @galaxyproject/gx-it-proxy, which still refers to the old version.

This PR updates the npx command.

For more context, see galaxyproject/gx-it-proxy#25

@dometto
Copy link
Contributor Author

dometto commented Apr 9, 2025

The tests for release 23.0 fail on all tests relating to starting Galaxy (test_cmd_start_...), seeminlgy not related to gx-it:

tests/test_operations.py::test_cmd_start[supervisor] FAILED              [ 14%]
tests/test_operations.py::test_cmd_start[systemd] FAILED                 [ 16%]
tests/test_operations.py::test_cmd_start_reports FAILED                  [ 18%]
tests/test_operations.py::test_cmd_start_with_gxit[supervisor] FAILED    [ 19%]
tests/test_operations.py::test_cmd_start_with_gxit[systemd] FAILED       [ 21%]
tests/test_operations.py::test_cmd_graceful[supervisor] FAILED           [ 22%]
tests/test_operations.py::test_cmd_graceful[systemd] FAILED              [ 24%]
tests/test_operations.py::test_cmd_restart_with_update FAILED            [ 26%]

Are these failures expected at the moment, or is some debugging in order?

@natefoo
Copy link
Member

natefoo commented Apr 16, 2025

I can't get these tests to fail locally and regardless, the old versions of Galaxy will pin an older Gravity release, so I'm going to merge. Thanks @dometto !

@natefoo natefoo merged commit 1497cb8 into galaxyproject:main Apr 16, 2025
6 of 7 checks passed
@dometto
Copy link
Contributor Author

dometto commented Jun 18, 2025

Gravity still is configured to run npx install gx-it-proxy instead of npx install @galaxyproject/gx-it-proxy, which still refers to the old version.

This still seems to be the case on Galaxy 24.2 5.dev0 (version from the API). Is Galaxy not using the new version of Gravity yet?

I'm asking because this still prevents interactive tools from working on a newly configured instance.

@natefoo
Copy link
Member

natefoo commented Jun 18, 2025

I think I made a mistake with the 1.0.7 release, your change was supposed to be included but it was not. I just released 1.1.0 yesterday which will included it, but 24.2 won't have that, unfortunately.

@nsoranzo
Copy link
Member

I think I made a mistake with the 1.0.7 release, your change was supposed to be included but it was not. I just released 1.1.0 yesterday which will included it, but 24.2 won't have that, unfortunately.

@natefoo If it's an important bugfix, we can update the pinned gravity version in lib/galaxy/dependencies/pinned-requirements.txt for release_24.2 as well.

@natefoo
Copy link
Member

natefoo commented Jun 18, 2025

It'd probably be better if I made a 1.0.8 release for it, 1.1.0 has some new stuff that is probably fine but could break, so best to keep those changes to the new version of Galaxy.

@natefoo
Copy link
Member

natefoo commented Jun 19, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants