Skip to content

[25.0] Prevent DCE collections from being renamed #20534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ahmedhamidawan
Copy link
Member

Fixes https://help.galaxyproject.org/t/how-can-i-rename-a-paired-fastq-file/15784

Adds a renameable prop to DetailsLayout in addition to the existing writeable prop, because this way, we allow anonymous user histories to still be renamed (#20197) and in the case of the collection layout, DCEs are made not-renameable and unwriteable.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

Fixes https://help.galaxyproject.org/t/how-can-i-rename-a-paired-fastq-file/15784

Adds a `renameable` prop to `DetailsLayout` in addition to the existing `writeable` prop, because this way, we allow anonymous user histories to still be renamed (galaxyproject#20197) and in the case of the collection layout, DCEs are made not-renamaeable and unwriteable.
@mvdbeek
Copy link
Member

mvdbeek commented Jun 21, 2025

The AXE thing seems real ?

@ahmedhamidawan
Copy link
Member Author

The AXE thing seems real ?

Should be fixed now!

@mvdbeek mvdbeek merged commit 8903af6 into galaxyproject:release_25.0 Jun 22, 2025
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants