Skip to content

[25.0] Add redis conditional dependency #20502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: release_25.0
Choose a base branch
from
Open

[25.0] Add redis conditional dependency #20502

wants to merge 4 commits into from

Conversation

davelopez
Copy link
Contributor

Fixes #20462 (comment)

Should I target older versions, or is dev fine?

How to test the changes?

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@github-actions github-actions bot added this to the 25.1 milestone Jun 18, 2025
mvdbeek
mvdbeek reviewed Jun 18, 2025
View reviewed changes
mvdbeek
mvdbeek approved these changes Jun 18, 2025
View reviewed changes
Copy link
Member

@mvdbeek mvdbeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do 25.0 ?

@davelopez davelopez marked this pull request as draft June 18, 2025 12:46
@davelopez davelopez force-pushed the add_redis_conditional_dependency branch from 7eaa7c7 to 9ea62b1 Compare June 18, 2025 12:51
@davelopez davelopez changed the base branch from dev to release_25.0 June 18, 2025 12:51
@github-actions github-actions bot changed the title Add redis conditional dependency [25.0] Add redis conditional dependency Jun 18, 2025
@davelopez davelopez marked this pull request as ready for review June 18, 2025 12:51
@bernt-matthias
Copy link
Contributor

Hmm. How about people that do not use redis for celery?

Regarding redis, there are additional install steps needed anyway, or?

nsoranzo
nsoranzo reviewed Jun 19, 2025
View reviewed changes
@nsoranzo
Copy link
Member

Needs a make format now, sorry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nsoranzo nsoranzo nsoranzo left review comments

@bernt-matthias bernt-matthias bernt-matthias left review comments

@mvdbeek mvdbeek mvdbeek approved these changes

Assignees
No one assigned
Labels
area/dependencies kind/bug kind/enhancement
Projects
None yet
Milestone
25.1
Development

Successfully merging this pull request may close these issues.

AttributeError: 'Connection' object has no attribute 'register_connect_callback'
4 participants
@davelopez @bernt-matthias @nsoranzo @mvdbeek