-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Automatically initialize Apptainer #20447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
natefoo
wants to merge
14
commits into
galaxyproject:dev
Choose a base branch
from
natefoo:auto-init-apptainer
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I added some unit tests, I am a little iffy on adding to the integration tests since they are a good bit slower and our tests are already slow enough. Since the Apptainer resolvers are just the Singularity resolvers in a trenchcoat we wouldn't be testing anything new. I can add a test of the auto-init functionality though if we want. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ultimately the goal here is to support easier production deployments where Galaxy itself does not have to be installed in the shared FS. Admins can configure the
tool_dependency_dir
to be on the shared FS and then we can just use Apptainer + a galaxy-job-execution container for runningset_meta()
.I should probably add a few more tests but wanted to get this out here for comment in case people don't like the direction I've taken.
How to test the changes?
(Select all options that apply)
I've includedI will include appropriate automated tests.container_resolvers
wheres/singularity/apptainer/
auto_init: true
prefix
and/orexec
to change where Apptainer is installed.License