Skip to content

Conversation

@ksuderman
Copy link
Contributor

When themes are disabled, either by setting galaxy_manage_themes: false or if there are no galaxy_themes_subdomains, the use of the YAML folded block scalar operator (>) causes the variable themes_config_file_by_host to evaluate the string '{ }' rather than to an empty dictionary. This causes Galaxy's config parser to fail when it tries to call .items() on a string.

With this PR:

  1. When themes are disabled (galaxy_manage_themes: false or no galaxy_themes_subdomains):
    - Returns an empty dict {}
    - Not a string "{ }"
  2. When themes are enabled (both conditions true):
    - Uses _themes_config_file_by_host which is a proper YAML dictionary
    - Each host is a key with its corresponding theme config file as the value

Closes #231

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unexpected value for keys ending with _by_host in galaxy.yml

1 participant