Netcore #37
Open
Netcore #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…NET Core Identity
…t for this testing project which doesn't really matter...
…each type so this test can pass already. Good - no need for ReflectionMagic to target netcore or netstandard
…gure out DI for testing
- Email and name searches are now by normalized fields
…g, and change to RemoveAll instead of replacing list references which could silently surprise consumers.
…so long with current test runner for NET Core
…upport. Because this is ASP.NET Core, that's what I'm looking at as far as what frameworks to support. Not like UWP would make sense for this adapter. Add net451 as a testing framework also Bump package versions and remove driver - it's brough to test projects as a transitive dependency Fixes g0t4#21
Move old indexes so people have to decide if they want to keep these when migrating from ASP.NET Identity v2 - they might do this if they have their own queries on non normalized fields, that's why I didn't obsolete these methods. Fixes g0t4#22
…ntional spot with Add, this is for advanced scenarios and I don't want people to see it unless they go looking for it for a specific use case. This will avoid confusion for people that want to use defaults with AddIdentityWithMongoStores methods.
…istrations - Update docs
Closes g0t4#24
…e user doesn't exist. Previously was throwing an exception under the cover by the MongoDB Linq provider when converting id from string to objectid. This caused some people with v2 of Identity to have issues with users that have cookies that have old user ids before migrating to MongoDB Identity Stores. Small edge case but seems reasonable to do this, as this method already returns null if a user doesn't exist. Not a huge perf overhead either, and if it is a perf reason for someone they may want to write their own provider anyways. Fixes g0t4#14
… if people query this directly, DateTimeOffset? doesn't serialize the same and we don't really need this type under the covers.
# Conflicts: # README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conflicts:
README.md