Refactor #1
Open
Refactor #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Bump version of preact-custom-element to 4.5.0 - Add @web/test-runner-puppeteer as a dev dependency - Add TypeScript as a dev dependency - Update package-lock.json with new versions of dependencies - Enhance index.d.ts to include serializable option in Options type - Refactor index.js to support serializable shadow roots and improve private data handling - Introduce index.ts for TypeScript support with type definitions - Update tsconfig.json to include necessary compiler options and settings
- Added `oxlint` as a dependency for linting. - Updated package.json scripts to include TypeScript build and linting commands. - Introduced a new TypeScript configuration file (tsconfig.build.json) for building the project. - Refactored index.js and index.ts to improve type safety and error handling. - Removed deprecated attributeChangedCallback and disconnectedCallback methods. - Enhanced the createShadowRoot function to handle errors more gracefully. - Updated to use unknown type for props and attributes for better type safety. - Added source maps for TypeScript output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.