記録機能の追加（feature/recoding）の改善 #19
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taki3210
changed the title
taki3210
requested review from
Hosoda-abo,
cocoa04263,
gooharu,
kantacky and
moshi18
kantacky
reviewed
Oct 31, 2025
Comment on lines
66
to
85
| function writeRawRecords(records: any[]): boolean { | ||
| try { | ||
| fs.writeFileSync(DATA_FILE, JSON.stringify(records, null, 2), 'utf8') | ||
| return true | ||
| } catch (err) { | ||
| console.error('writeRawRecords error:', err) | ||
| return false | ||
| } | ||
| try { | ||
| fs.writeFileSync(DATA_FILE, JSON.stringify(records, null, 2), 'utf8') | ||
| return true | ||
| } catch (err) { | ||
| console.error('writeRawRecords error:', err) | ||
| return false | ||
| } | ||
| } | ||
|
|
||
| function writeRecords(records: DailyRecord[]): boolean { | ||
| try { | ||
| const out = records.map(serializeRecord) | ||
| fs.writeFileSync(DATA_FILE, JSON.stringify(out, null, 2), 'utf8') | ||
| return true | ||
| } catch (err) { | ||
| console.error('writeRecords error', err) | ||
| return false | ||
| } | ||
| try { | ||
| const out = records.map(serializeRecord) | ||
| fs.writeFileSync(DATA_FILE, JSON.stringify(out, null, 2), 'utf8') | ||
| return true | ||
| } catch (err) { | ||
| console.error('writeRecords error', err) | ||
| return false | ||
| } | ||
| } |
There was a problem hiding this comment.
前のPRでコメント出来ていなくて申し訳ないんだけど、これだと、意図したとおりに保存できる実装じゃないんじゃないかなぁ...
テキストで説明するの難しいので、次回のプロジェクトの時にでも...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
記録機能の追加（feature/recoding）を改善したものです。
・route.tsでdailyRecord.tsを再呼び込みしなくて済むようにした
・2週間のうちの一日目のみうまく動作しなかった部分を改善した
自分でテストすると動作しました。