-
Notifications
You must be signed in to change notification settings - Fork 0
記録機能の追加 #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
記録機能の追加 #17
Conversation
|
コードはわからないけど、実装はできてそうな気がする |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
差分が多いとレビューが大変になる(質も落ちる、細かいところまで目が届きにくくなる)ので、次からは、できるだけ細かい粒度でPRが作られるとよいと思います!
1変更1PR (1ブランチ) を心がけるとよいかも?
このあたりの運用はチームで話し合ってみてください!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
テスト用のデータを入れて、想定した動作をするかどうか、確認できると良さそうです。
もしかして、もうすでにしたかな?その場合は、その旨をPRの説明に含められるとよいと思います!
| @@ -0,0 +1 @@ | |||
| [] No newline at end of file | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
動作確認に使った仮のUIも入れたままです。
src/app/api/records/route.tsを主に見ていただけるといいです。