subscriptions: Convert GraphQL errors to nil if they are empty #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reduces the likelyhood of servers that use graphqlws to send an empty array of errors along with subscription updates to clients. This also makes subscriptions work better in GraphiQL, where previously, the empty array of errors would make GraphiQL-Subscriptions-Fetcher would treat all updates as errors: https://github.com/apollographql/GraphiQL-Subscriptions-Fetcher/blob/master/src/fetcher.ts#L36 (An empty array is considered truthy).
ghost
added
the
|
Tests are passing and the change was also tested with GraphiQL and the pending example PR (#24). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces the likelyhood of servers that use graphqlws to send
an empty array of errors along with subscription updates to clients.
This also makes subscriptions work better in GraphiQL, where
previously, the empty array of errors would make
GraphiQL-Subscriptions-Fetcher would treat all updates as errors:
https://github.com/apollographql/GraphiQL-Subscriptions-Fetcher/blob/master/src/fetcher.ts#L36
(An empty array is considered truthy).