Clarify HTTP GET route handling in exercise 3.18 #4170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The text "handling of the api/persons/:id and info routes" is a bit ambiguous since exercise 3.17 requires you to also implement a api/persons/:id route, as did exercise 3.15. I think adding HTTP GET in the exercise makes it a bit more clear to the student that it is the GET /api/persons/:id and GET /info routes that are to be updated in this exercise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The text "handling of the api/persons/:id and info routes" is a bit ambiguous since exercise 3.17 requires you to also implement a route with path api/persons/:id (HTTP PUT request), as did exercise 3.15 (HTTP DELETE request). I think adding HTTP GET in the exercise makes it a bit more clear to the student that it is the GET /api/persons/:id and GET /info routes that are to be updated in this exercise.