Add googlemapfield class name so JS actually binds to the fields #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… correctly, but not to the field holder
…ing visible sometimes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this is just my implementation, but this module doesn't work out of the box with SS5 without the following:
:visiblepsuedo-class trigger as the Google Maps callback function often triggers before the page is rendered (meaning the field is sometimes not yet visible as the HTML isn't rendered).This does remove
extraClassesfrom the holder template, not sure if this is a bad idea or not really - but the JS breaks without this as multiple elements match the.googlemapfieldselector but only the inner field has the relevantdata-attributes