Allow to use symbol plus in query #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the query with complex ariphmetics are not correctly encoded. Example: ``` "sum:Foo.as_count() + sum:Foo.bar.as_count()" # => "sum:Foo.as_count()%20+%20sum:Foo.bar.as_count()" ``` The symbol `+` was not encoded. Datadog API treat `+` as concatination symbol and convert query to ``` "sum:Foo.as_count() sum:Foo.bar.as_count()" ``` and responses with error message. Replace `URI.encode` with `URI.encode_path_segment`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the query with complex ariphmetics are not correctly encoded.
Example:
The symbol
+was not encoded. Datadog API treat+as concatinationsymbol and convert query to
and responses with error message.
Also it solves deprecation warning for Crystal 1.4.1:
Solution
Replaces
URI.encodewithURI.encode_path_segment