-
Notifications
You must be signed in to change notification settings - Fork 382
Bugfix/1827 invalid cross device link #1829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/1827 invalid cross device link #1829
Conversation
Creating the temporary file next to the target path (making sure it's on the same device) solves this issue. Took inspiration from filesystem_spec/fsspec/utils.py Lines 616 to 618 in 6cc68c7
This seems to work as expected with shutil.move .
Then It is difficult to mock the cross-device issue as it requires a temporary file on another device than the target device, so I mock this as an EXDEV at |
Why do the tests fail? These tests sporadically fail locally, but not always. And I get these errors also sporadically on master. |
I'm not sure if this is the cleanest way to do it. I'm also not sure if |
Fixes #1827