Default values for reuse annotate, enabling a pre-commit hook
#761
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carmenbianca
force-pushed
the
annotate-hook
branch
2 times, most recently
from
54c2a92 to
12ec884
Compare
carmenbianca
commented
Jun 17, 2023
src/reuse/_config.py
Outdated
| # precedence. | ||
| for o_path, options in self.override_annotate_options.items(): | ||
| o_path = Path(o_path).expanduser() | ||
| if path.is_relative_to(o_path): |
There was a problem hiding this comment.
Apparently this method doesn't exist in Python ≤3.8.
There was a problem hiding this comment.
I think it can be replaced with relative_to, which exists in 3.8 though. From the 3.9 source:
def is_relative_to(self, *other):
"""Return True if the path is relative to another path or False.
"""
try:
self.relative_to(*other)
return True
except ValueError:
return FalseIn newer versions both functions are based on with_segments which doesn't exist in 3.8 or 3.9 yet.
carmenbianca
force-pushed
the
annotate-hook
branch
from
b985333 to
c4c4a0e
Compare
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
carmenbianca
force-pushed
the
annotate-hook
branch
from
c4c4a0e to
86cdb83
Compare
|
Is there still interest in these changes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #68
Fixes #534
WIP