Skip to content

Add "requests" as a dependency #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@

`valorant.py` is an unofficial API wrapper for Riot Games' Valorant API endpoints. It's modern, easy to use, feature-rich, and intuitive!

**[\*\*]** *Just a little note, the developement of this project will slow down a bit as I enter into college and other life stuff, but rest assured I don't plan on abandoning this. Thanks for understanding!*

## Features

+ **Simple:** High-level abstraction of API interactions; easy to use and easy to customize.
Expand Down Expand Up @@ -70,4 +72,4 @@ Have a bug or issue? Need help with the API? Open an [issue](https://github.com/

## Contributing

Head over to the [**Contributing Guide**](https://github.com/frissyn/valorant.py/blob/master/.github/CONTRIBUTING.md) page.
Head over to the [**Contributing Guide**](https://github.com/frissyn/valorant.py/blob/master/.github/CONTRIBUTING.md) page.
3 changes: 2 additions & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
long_description_content_type="text/markdown",

python_requires=">=3.8.0",
install_requires=["requests"]

zip_safe=False,
packages=["valorant", "valorant/local", "valorant/objects"],
Expand All @@ -35,4 +36,4 @@
"Programming Language :: Python :: 3.9",
"Topic :: Software Development"
]
)
)
7 changes: 4 additions & 3 deletions tests/client/test_account.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,12 @@ def test_account(self):
"_7wNdRyj4cljexSBoGCESzJglohUbAM4H5kw"
)

self.assertEqual(getattr(acc, "gameName", None), "frissyn")
self.assertIsInstance(acc, valorant.AccountDTO)
self.assertEqual(getattr(acc, "gameName", None), "frissyn")

def test_account_by_name(self):
acc = self.client.get_user_by_name("frissyn#6969")
# Using my static alternate account.
acc = self.client.get_user_by_name("friss#sick")

self.assertEqual(getattr(acc, "gameName", None), "frissyn")
self.assertIsInstance(acc, valorant.AccountDTO)
self.assertEqual(getattr(acc, "gameName", None), "friss")