-
Notifications
You must be signed in to change notification settings - Fork 36
MusicXML: support repeat and alternative #83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
eoma
wants to merge
17
commits into
frescobaldi:master
Choose a base branch
from
eoma:fix-repeat-and-alternative-for-musicxml
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
MusicXML: support repeat and alternative #83
eoma
wants to merge
17
commits into
frescobaldi:master
from
eoma:fix-repeat-and-alternative-for-musicxml
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0ba0f19
to
b92da28
Compare
Also, put repeat barline on correct side of bar.
Add the end repeat sign to the previous bar if the current has no content.
The tests include a choir staff consisting of a simple score with standard 2 repeats and 3 repeats, and a score with two voices.
b92da28
to
9dea3ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt at having proper export to MusicXML when it contains repeats with and without alternatives, however many times one would like to repeat the music with varying numbers of endings.