-
Notifications
You must be signed in to change notification settings - Fork 1
production readiness additional information defined in the plugin #186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
plugins/kubernetesapi-report/src/main/java/com/freenow/sauron/plugins/KubernetesApiReport.java
Outdated
Show resolved
Hide resolved
...rt/src/main/java/com/freenow/sauron/plugins/commands/KubernetesGetDeploymentSpecCommand.java
Outdated
Show resolved
Hide resolved
...rt/src/main/java/com/freenow/sauron/plugins/commands/KubernetesGetDeploymentSpecCommand.java
Outdated
Show resolved
Hide resolved
...sapi-report/src/main/java/com/freenow/sauron/plugins/readers/KubernetesContainersReader.java
Outdated
Show resolved
Hide resolved
...sapi-report/src/main/java/com/freenow/sauron/plugins/readers/KubernetesContainersReader.java
Outdated
Show resolved
Hide resolved
...sapi-report/src/main/java/com/freenow/sauron/plugins/readers/KubernetesContainersReader.java
Outdated
Show resolved
Hide resolved
...netesapi-report/src/test/java/com/freenow/sauron/plugins/KubernetesContainersReaderTest.java
Outdated
Show resolved
Hide resolved
...netesapi-report/src/test/java/com/freenow/sauron/plugins/KubernetesContainersReaderTest.java
Show resolved
Hide resolved
plugins/kubernetesapi-report/src/main/java/com/freenow/sauron/plugins/KubernetesApiReport.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we discussed, here some minor changes we can apply. 👍🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I provided some feedback
...sapi-report/src/main/java/com/freenow/sauron/plugins/readers/KubernetesContainersReader.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about the StatefulSets and DaemonSets? do they also covered?
...rt/src/main/java/com/freenow/sauron/plugins/commands/KubernetesGetDeploymentSpecCommand.java
Outdated
Show resolved
Hide resolved
...sapi-report/src/main/java/com/freenow/sauron/plugins/readers/KubernetesContainersReader.java
Outdated
Show resolved
Hide resolved
They are mostly used by SRE team services which are not the target of this ticket but we can talk about it to be covered. |
This is the first try to add Kubernetes deployment readiness to the Sauron