Skip to content

Upgrade xero-php-oauth2 to v9/v10 #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −1
Open

Upgrade xero-php-oauth2 to v9/v10 #136

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
],
"require": {
"php": "^8.2|^8.3|^8.4",
"xeroapi/xero-php-oauth2": "^7.1|^8.0",
"xeroapi/xero-php-oauth2": "^7.1|^8.0|^9.0|^10.0",
Copy link

@gemini-code-assist gemini-code-assist bot Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

While allowing newer versions of xero-php-oauth2 is a good enhancement, versions 9 and 10 introduce significant breaking changes as you've noted in the PR description. To adhere to semantic versioning principles, this change should be accompanied by a new major version release for webfox/laravel-xero-oauth2 (e.g., v5.0.0).

This signals to users that the update contains backward-incompatible changes (even if they are in a dependency) and that they need to review their code for compatibility. Releasing this as a minor or patch version could unexpectedly break users' applications.

I also strongly recommend documenting these breaking changes in CHANGELOG.md as part of the new major release.

"laravel/framework": "^10.0|^11.0|^12.0"
},
"require-dev": {
Expand Down