Display gas report table for fork contracts #3876
Open
+112
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is part of the following stack:
Change managed by git-spice. |
ddoktorski
requested review from
MKowalski8 and
franciszekjob
and removed request for
a team
This was referenced Oct 28, 2025
franciszekjob
approved these changes
Oct 29, 2025
|
|
||
| #[derive(Debug, Clone, PartialOrd, PartialEq, Ord, Eq)] | ||
| pub enum ContractId { | ||
| TestContract(ContractName), |
There was a problem hiding this comment.
nit: wdyt?
Suggested change
| TestContract(ContractName), | |
| LocalContract(ContractName), |
cptartur
reviewed
Oct 31, 2025
|
|
||
| #[derive(Debug, Clone, PartialOrd, PartialEq, Ord, Eq)] | ||
| pub enum ContractId { | ||
| TestContract(ContractName), |
Comment on lines
+126
to
+132
| let name = match self { | ||
| ContractId::TestContract(name) => format!("{name} Contract"), | ||
| ContractId::ForkedContract(class_hash) => { | ||
| format!( | ||
| "forked contract\n(class hash: {})", | ||
| shorten_felt(class_hash.0) | ||
| ) |
There was a problem hiding this comment.
Capitalization is inconsistent between these
| ContractId::ForkedContract(class_hash) => { | ||
| format!( | ||
| "forked contract\n(class hash: {})", | ||
| shorten_felt(class_hash.0) |
There was a problem hiding this comment.
I wonder if it should be configurable to show full contract urls, maybe let's just add an issue for that, maybe it can be integrated if we ever add a -v flag to foundry.
Comment on lines
+3
to
+8
| pub(super) fn shorten_felt(felt: Felt) -> String { | ||
| let padded = format!("{felt:#066x}"); | ||
| let first = &padded[..4]; | ||
| let last = &padded[padded.len() - 4..]; | ||
| format!("{first}…{last}") | ||
| } |
There was a problem hiding this comment.
The first 3 characters area always 0x0, maybe we should also show 4 after that? It's not very useful to show that beginning otherwise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #3660