feat(anvil): added anvil_impersonateSignature
#11195
Open
+147
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
requested changes
Aug 4, 2025
Soubhik-10
changed the title
anvilRecoverSignature
Soubhik-10
requested review from
DaniPopes,
klkvr,
grandizzy,
yash-atreya and
zerosnacks
as code owners
…ndry into anvil-recover-sig
mattsse
requested changes
Aug 6, 2025
Comment on lines
+100
to
+104
| /// A custom ecrecover precompile that supports cheat-based signature overrides. | ||
| #[derive(Clone, Debug)] | ||
| pub struct CheatEcrecover { | ||
| cheats: Arc<CheatsManager>, | ||
| } |
There was a problem hiding this comment.
after the impls of this?
Soubhik-10
changed the title
anvilRecoverSignatureanvilImpersonateSignature
Soubhik-10
changed the title
anvilImpersonateSignatureanvil_impersonateSignature
mattsse
requested changes
Aug 8, 2025
Comment on lines
+100
to
+104
| /// A custom ecrecover precompile that supports cheat-based signature overrides. | ||
| #[derive(Clone, Debug)] | ||
| pub struct CheatEcrecover { | ||
| cheats: Arc<CheatsManager>, | ||
| } |
Comment on lines
+123
to
+126
| let v = padded[63]; | ||
| if !(padded[32..63].iter().all(|&b| b == 0) && (v == 27 || v == 28)) { | ||
| return Ok(PrecompileOutput::new(ECRECOVER_BASE, Bytes::new())); | ||
| } |
There was a problem hiding this comment.
I think we can skip this because we can treat this as valid if the sig is an invalid but impersonated signature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #5381