Skip to content

refactor(verify): remove redundant logging in Etherscan provider #11048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

refactor(verify): remove redundant logging in Etherscan provider #11048

wants to merge 7 commits into from

Conversation

crStiv
Copy link

@crStiv crStiv commented Jul 19, 2025

Removed redundant warn!/error! calls to reduce log noise and improve clarity

mattsse
mattsse requested changes Jul 24, 2025
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this makes sense, but there's no need to put changes as docs

@crStiv
Copy link
Author

crStiv commented Jul 26, 2025

this makes sense, but there's no need to put changes as docs

tnx for the review, does it make sense now?

@crStiv crStiv requested a review from mattsse July 26, 2025 15:14
kaxhnet
kaxhnet previously approved these changes Jul 26, 2025
View reviewed changes
Copy link

@kaxhnet kaxhnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lsh9

mattsse
mattsse requested changes Jul 27, 2025
View reviewed changes
@crStiv crStiv requested a review from mattsse July 27, 2025 15:51
zerosnacks
zerosnacks reviewed Aug 5, 2025
View reviewed changes
zerosnacks
zerosnacks reviewed Aug 5, 2025
View reviewed changes
@crStiv crStiv requested a review from zerosnacks August 5, 2025 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaxhnet kaxhnet kaxhnet left review comments

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@klkvr klkvr Awaiting requested review from klkvr klkvr is a code owner

@grandizzy grandizzy Awaiting requested review from grandizzy grandizzy is a code owner

@yash-atreya yash-atreya Awaiting requested review from yash-atreya yash-atreya is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@zerosnacks zerosnacks Awaiting requested review from zerosnacks zerosnacks is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
Foundry
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@crStiv @mattsse @grandizzy @zerosnacks @kaxhnet