-
Notifications
You must be signed in to change notification settings - Fork 2k
ENS naming for contracts #10605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
ENS naming for contracts #10605
Conversation
This reverts commit 9b88580.
Hi @abhijeetbhagat thanks for your PR, In my opinion, as a principle Foundry does not directly integrate third party services to remain a neutral actor. I am against recording metrics from users and collecting possibly identifying data such as IP addresses. |
Thanks for your comment @zerosnacks, we have two motivations for connecting to the service:
|
…foundry into ens-naming-for-contracts
Hi @conor10, thanks for your reply
In Ethers we maintained an
In Foundry we have at multiple occasions discussed the role of metrics to better evaluate how our users are using Foundry. In the spirit of open source and being conscious of our user's privacy we have arrived at the position that we do not collect data on our users, anonymised or not. This makes evaluating demand for features and measuring adoption challenging but I believe this is the right decision. I would recommend finding an alternative (technical) solution to measure adoption. |
@zerosnacks alright, we'll make the changes accordingly. we'll add the chain config related stuff in we have an endpoint that fetches an auto generated names. is calling this api fine for you? |
Motivation
this issue #10604
Solution
PR Checklist