Skip to content

feat: Add QmaxDynamic to allow unify Qmax , Qminmax, pertokenmax #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

iqbal-saraf
Copy link

This adds new quantizer namely QmaxDynamic which includes all functionality providing a dynamic version of Qmax, Qminmax and pertokenmax. Additionally, it allows perCh or pertoken quantization features.

Related issues or PRs

None

How to verify the PR

All previous tests build for Qmax, Qminmax and pertokenmax should invoke this new quantizer.

Was the PR tested

  • I have added >=1 unit test(s) for every new method I have added (if that coverage is difficult, please briefly explain the reason)
  • I have ensured all unit tests pass

Checklist for passing CI/CD:

  • All commits are signed showing "Signed-off-by: Name <[email protected]>" with git commit -signoff or equivalent
  • PR title and commit messages adhere to Conventional Commits
  • Contribution is formatted with tox -e fix
  • Contribution passes linting with tox -e lint
  • Contribution passes spellcheck with tox -e spellcheck
  • Contribution passes all unit tests with tox -e unit

Note: CI/CD performs unit tests on multiple versions of Python from a fresh install. There may be differences with your local environment and the test environment.

@github-actions github-actions bot added the feat label Jun 16, 2025
@iqbal-saraf iqbal-saraf mentioned this pull request Jun 16, 2025
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants