feat: Generic Rotation #117
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: cliu-us <[email protected]>
Signed-off-by: cliu-us <[email protected]>
| @@ -131,8 +132,10 @@ def __init__( | |||
| ) | |||
|
|
|||
| self.calib_iterator = [] # To simplify update of clipvals in forward() | |||
| self.quantize_m1 = Qbypass() | |||
| self.quantize_calib_m1 = Qbypass() | |||
| quant_m1_def = Qbypass() if "rot_" not in self.qm1_mode else RotQuantWrapper() | |||
There was a problem hiding this comment.
Would it make more sense to do the if condition as RotQuantWrapper() if "rot_" in self.qm1_mode else Qbypass()?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding base functionalities for generic rotation, e.g. Hadamard matrices.
Closes #104
How to verify the PR
Will add an unit test and example.
Was the PR tested