-
Notifications
You must be signed in to change notification settings - Fork 10
fix: IOS build error due to flutter_nfc_kit issue fixes. #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🧙 Sourcery has finished reviewing your pull request! Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Dhruv1797 - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a comment in the Podfile explaining why the platform version is set to 13.0.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
@AsCress @mariobehling @kienvo ✅All 3 CI checks have now passed successfully: Please review it once when you get a chance 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Dhruv1797 LGTM ! Nice work there !
@mariobehling Good to go. |
Here is the ios build preview:

Summary by Sourcery
Configure iOS deployment target to resolve build issues with flutter_nfc_kit plugin
Bug Fixes:
Build: