fix: open nfc settings when switched off #19
Merged
+59
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's Guide by SourceryThis pull request implements NFC availability checks and provides user guidance, including prompting the user to enable NFC and redirecting them to the appropriate settings on both Android and iOS platforms. It uses FlutterNfcKit for NFC checks and platform-specific methods for opening settings. Sequence diagram for handling NFC availabilitysequenceDiagram
participant User
participant Flutter App
participant FlutterNfcKit
participant Platform (Android/iOS)
User->>Flutter App: Triggers NFC action (e.g., writeImages)
Flutter App->>FlutterNfcKit: Check NFC availability
FlutterNfcKit->>Platform: Get NFC status
Platform-->>FlutterNfcKit: Returns NFC status (available, disabled, not_supported)
FlutterNfcKit-->>Flutter App: Returns NFC availability
alt NFC is disabled
Flutter App->>Flutter App: Show toast message "NFC is disabled. Please enable it."
alt Platform is Android
Flutter App->>Platform: Open NFC settings
else Platform is iOS
Flutter App->>Platform: Open App settings
end
else NFC is not supported
Flutter App->>Flutter App: Show toast message "This device does not support NFC."
else NFC is available
Flutter App->>Flutter App: Show toast message "Bring your phone near to the Magic Epaper Hardware"
Flutter App->>FlutterNfcKit: poll(timeout)
FlutterNfcKit->>Platform: Poll for NFC tag
Platform-->>FlutterNfcKit: Returns NFC tag
FlutterNfcKit-->>Flutter App: Returns NFC tag
end
Updated class diagram for NFCSettingsLauncherclassDiagram
class NFCSettingsLauncher {
+static const platform
+static Future<void> openNFCSettings()
}
note for NFCSettingsLauncher "Utility class to open NFC settings on Android and iOS"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @Dhruv1797 - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding error handling around the
AppSettings.openAppSettings()call for iOS, as it can fail if the user has restricted app settings access. - The
CHANNELconstant inMainActivity.ktshould be defined in a more central place (e.g. a shared constants file) to avoid potential mismatches.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Comment on lines
+17
to
+24
| if (call.method == "openNFCSettings") { | ||
| val intent = Intent(Settings.ACTION_NFC_SETTINGS) | ||
| intent.addFlags(Intent.FLAG_ACTIVITY_NEW_TASK) | ||
| startActivity(intent) | ||
| result.success(null) | ||
| } else { | ||
| result.notImplemented() | ||
| } |
There was a problem hiding this comment.
suggestion (bug_risk): Consider error handling for the platform intent.
In case startActivity fails (for example, if NFC settings are not available), adding try/catch around the intent launch could help avoid unexpected crashes.
Suggested change
| if (call.method == "openNFCSettings") { | |
| val intent = Intent(Settings.ACTION_NFC_SETTINGS) | |
| intent.addFlags(Intent.FLAG_ACTIVITY_NEW_TASK) | |
| startActivity(intent) | |
| result.success(null) | |
| } else { | |
| result.notImplemented() | |
| } | |
| if (call.method == "openNFCSettings") { | |
| try { | |
| val intent = Intent(Settings.ACTION_NFC_SETTINGS) | |
| intent.addFlags(Intent.FLAG_ACTIVITY_NEW_TASK) | |
| startActivity(intent) | |
| result.success(null) | |
| } catch (e: Exception) { | |
| result.error("UNAVAILABLE", "NFC Settings not available", null) | |
| } | |
| } else { | |
| result.notImplemented() | |
| } |
|
@kienvo please review it once. |
nfc-handing-demo.mp4Here is the demo video for nfc-handling for opening nfc settings-when nfc is disabled or off. |
|
The common build failed. Please resolve it. |
|
Hi @kienvo, |
|
Hi @kienvo, The common build and Android build have passed successfully. The only issue remaining is with the iOS build. According to the logs, CocoaPods is reporting a compatibility issue for the pod "flutter_nfc_kit", which is the same as before—I haven’t made any changes to it. Should i update this dependency and push changes: |
mariobehling
approved these changes
Apr 16, 2025
mariobehling
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What’s implemented:
Files Modified:
Summary by Sourcery
Improve NFC handling by adding comprehensive NFC availability checks, user notifications, and platform-specific settings navigation
New Features:
Bug Fixes:
Enhancements: