Skip to content

Modify Powered-by logo to eventyay logo #592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 18, 2025

Conversation

Sak1012
Copy link
Member

@Sak1012 Sak1012 commented Mar 23, 2025

This PR partially resolves #178 replaces the ticketing powered by logo in the pdf tickets with eventyay logo

Before:
image

After:
image

Summary by Sourcery

Enhancements:

  • Replaces the 'powered by' logo with the eventyay logo.

Copy link
Contributor

sourcery-ai bot commented Mar 23, 2025

Reviewer's Guide by Sourcery

This pull request replaces the 'powered by pretix' logo with the 'powered by eventyay' logo in the generated PDF tickets. The image path in src/pretix/base/pdf.py was updated to point to the new logo.

Updated class diagram for PDF generation

Loading
classDiagram
  class PDFGenerator {
    - _draw_poweredby(canvas: Canvas, op: OrderPosition, o: dict)
  }
  note for PDFGenerator._draw_poweredby "Replaced 'powered_by_pretix' logo with 'powered_by_eventyay' logo"

File-Level Changes

Change Details Files
Replaced the 'powered by pretix' logo with the 'powered by eventyay' logo in the PDF ticket generation.
  • Updated the image path to reflect the new logo.
  • The image path now points to the eventyay logo.
src/pretix/base/pdf.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Sak1012 - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider renaming the content variable to theme for better clarity.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@Sak1012 Sak1012 requested a review from mariobehling March 23, 2025 06:47
@Sak1012
Copy link
Member Author

Sak1012 commented Mar 24, 2025

This PR also partially resolves #421 although the preview shows the pretix logo and clicking on eventyay Logo adds the old logo, once saved and when the pdfs are generated eventyay logo is present

Preview:
image

Actual Ticket
image

@Sak1012 Sak1012 requested a review from norbusan March 24, 2025 15:23
@Sak1012
Copy link
Member Author

Sak1012 commented Mar 24, 2025

Now this PR completely resolves #421 with the editor showing the proper logo

Updated Preview:
image

@mariobehling
Copy link
Member

What about the Docker PR build?

@Sak1012
Copy link
Member Author

Sak1012 commented Mar 26, 2025

It is now working 👍🏿

@mariobehling mariobehling merged commit 2bfb277 into fossasia:development Apr 18, 2025
1 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix branding

None yet

3 participants