-
Notifications
You must be signed in to change notification settings - Fork 98
Modify Powered-by logo to eventyay logo #592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis pull request replaces the 'powered by pretix' logo with the 'powered by eventyay' logo in the generated PDF tickets. The image path in Updated class diagram for PDF generationclassDiagram
class PDFGenerator {
- _draw_poweredby(canvas: Canvas, op: OrderPosition, o: dict)
}
note for PDFGenerator._draw_poweredby "Replaced 'powered_by_pretix' logo with 'powered_by_eventyay' logo"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Sak1012 - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider renaming the
content
variable totheme
for better clarity.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This PR also partially resolves #421 although the preview shows the pretix logo and clicking on |
Now this PR completely resolves #421 with the editor showing the proper logo |
What about the Docker PR build? |
It is now working 👍🏿 |
This PR partially resolves #178 replaces the
ticketing powered by
logo in the pdf tickets with eventyay logoBefore:

After:

Summary by Sourcery
Enhancements: