Fix: Replaced Black, isort, Flake8 with Ruff and Updated dependencies

[alikhere]

Description

This pull request simplifies the tooling in the project by replacing Black, isort, Flake8, and Pycodestyle with Ruff. The following changes have been made:

• Removed the following unnecessary dependencies from the dev section of pyproject.toml as Ruff replaces them:

  • isort
  • flake8
  • pycodestyle
  • pyflakes
  • pep8-naming

• Added Ruff as a dev dependency (ruff = "^0.11.0") to the pyproject.toml file. This consolidates both linting and formatting tasks under one tool.

• Updated the pyproject.toml file to configure Ruff:

  • Added format settings to use spaces for indentation and enforce single quotes:

    [tool.ruff]
    format = { indent-style = "space", quote-style = "single" }

  • Updated the linting rules to include errors (E), warnings (W), flake-style issues (F), and ignored imports (I):

    lint = { select = ["E", "F", "W", "I"] }

  • Configured Ruff to recognize pretix as a known first-party package for sorting imports:

    isort = { known-first-party = ["pretix"] }

• Updated GitHub Actions Workflow:

  • Replaced isort and flake8 jobs with a single Ruff job in .github/workflows/style.yml.
  • Added the following command to run Ruff for linting and formatting:

    ruff check --fix . && ruff format .

• No Functional Changes:

  • This PR only updates code style and formatting. No functional changes have been made.

Fixes

• This PR fixes issue Reformat Python code with Ruff #556.

[sourcery-ai]

The pull request #580 has too many files changed.

We can only review pull requests with up to 300 changed files, and this pull request has 523.

[hongquan]

Sorry, we forgot to mention that single quote (') is preferred.

[hongquan]

You need to update GH actions as well.

[hongquan]

Hi @alikhere, the title of PR, please capitalize the beginning of sentence.
The common rule is that, any message for human to read, please apply grammar and spelling rule learned in school.

[alikhere]

ok

[alikhere]

@hongquan Could you please review the PR.

[hongquan]

@alikhere The purpose of "style" GH Action is to check if submitted code conform to standard, so it should not fix or write the code.

Your GH Action command is writing changes to the code:

ruff check --fix . && ruff format .

[hongquan]

Did you test your changes in your localhost?

[alikhere]

@alikhere The purpose of "style" GH Action is to check if submitted code conform to standard, so it should not fix or write the code.

Your GH Action command is writing changes to the code:

ruff check --fix . && ruff format .

sorry my bad, it should be

        ruff check .

[alikhere]

Did you test your changes in your localhost?

I tried to setup project locally using Dockerfile but getting error while buiding docker image.

[hongquan]

You just need to test the lint tool, you don't need to run the application, don't need to setup Docker.
Btw, please increase line length to 120.

[alikhere]

You just need to test the lint tool, you don't need to run the application, don't need to setup Docker. Btw, please increase line length to 120.

I have tested the linting tool by running ruff check . and verified that it detects linting issues based on the selected rules (E, F, W, I)

[hongquan]

Please configure Ruff to ignore F405 error in settings.py files.
It would be nice if you can read those Ruff report and decide which errors can be ignored, which errors should be fixed later.

[alikhere]

Please configure Ruff to ignore F405 error in settings.py files. It would be nice if you can read those Ruff report and decide which errors can be ignored, which errors should be fixed later.

I have tested the changes, and now ruff successfully ignores F405 in the relevant settings.py files.

[hongquan]

Every time you make some changes, you should show the report so that I can see and determine what should do next.
How about this idea:

It would be nice if you can read those Ruff report and decide which errors can be ignored, which errors should be fixed later.

Can you do or not?

[alikhere]

Every time you make some changes, you should show the report so that I can see and determine what should do next. How about this idea:

It would be nice if you can read those Ruff report and decide which errors can be ignored, which errors should be fixed later.

Can you do or not?

Good idea, i can do that.

[alikhere]

Please configure Ruff to ignore F405 error in settings.py files. It would be nice if you can read those Ruff report and decide which errors can be ignored, which errors should be fixed later.

Report

1. Resolved Merge Conflicts

• New code is added to upstream development branch which caused conflicts with my branch so i fetch the latest changes and resolved the conflicts.

2. Ignored F405 in settings.py

Before ruff was reporting F405 warnings in settings.py.

After that i added the following rule to pyproject.toml

[tool.ruff.lint.per-file-ignores]
"*/settings.py" = ["F405"]

then ran ruff check . and verified that Ruff no longer reports F405 in settings.py.

3. Applied Ruff Formatting on Merged Files

Since merge conflicts introduced new code, I ran ruff format .
This applied Ruff's formatting rules (line length 120, single quotes, etc.) to the updated files.

All changes have been tested, and Ruff is now correctly ignoring F405 in settings.py.

[hongquan]

@alikhere I wonder if you are just repeating ChatGPT answer or you did put some personal thought to your work. The last comment #580 (comment) is not related to what I suggested you to do. It is just a repetition of #580 (comment).

[alikhere]

@alikhere I wonder if you are just repeating ChatGPT answer or you did put some personal thought to your work. The last comment #580 (comment) is not related to what I suggested you to do. It is just a repetition of #580 (comment).

Apologies for the misunderstanding. I initially thought you wanted a summary of the changes I made, rather than an analysis of the ruff report itself. I will now go through the report carefully identify which issues should be ignored or fixed.

[mariobehling]

Hello @alikhere any updates? Are you still on this?

[alikhere]

Hello @alikhere any updates? Are you still on this?

Yeah,
I have resolved the merge conflicts and ran ruff check ..

After running ruff check ., I found the following issues:

E501: Line too long (129 > 120)

E722: Bare except block

E741: Ambiguous variable names (e.g., l, O, I)

I’ve shared the report with you. Could you please advise on how to proceed with fixing these issues?
Should I address these issues or ignore any of them based on the project’s needs?

[hongquan]

E501: Line too long (129 > 120)

These errors are easy to fix. Please help fix.

E722: Bare except block
E741: Ambiguous variable names (e.g., l, O, I)

These errors will not be quick to fix, because they require you to understand the surrounding code. Then let add them to ignore list.

[alikhere]

@hongquan Thanks for the feedback!

• I have fixed the E501 issues (long lines >120 chars).

• Added E722 and E741 to the ignore list in pyproject.toml as suggested.

[hongquan]

@alikhere Please merge "development" branch to your branch to follow up with the latest changes in "development".

[alikhere]

@hongquan Merged

[hongquan]

@alikhere Why did you add your .env file to the repository?

[alikhere]

@hongquan I added the .env file while setting up the project locally for testing. I just removed it and updated the PR.

[mariobehling]

Docker build is failing. Please check.

[hongquan]

@alikhere Could you please resolve conflict?

[alikhere]

@alikhere Could you please resolve conflict?

I was little busy, i will resolve and inform you.

[alikhere]

@mariobehling @hongquan Docker build fixed.

[hongquan]

Please help resolve conflict.

[alikhere]

@hongquan @mariobehling Done!

[hongquan]

@alikhere New conflict appears, please resolve.