Skip to content

Chain id info added to err #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

Chain id info added to err #12

wants to merge 6 commits into from
+34 −5

Conversation

@ddomeke
Copy link
Collaborator

@ddomeke ddomeke commented Nov 4, 2025

No description provided.

@ddomeke ddomeke changed the title Duran/chain id info added to err Chain id info added to err Nov 4, 2025
@ddomeke ddomeke requested a review from aomerk November 5, 2025 11:48
@aomerk
Copy link
Contributor

aomerk commented Nov 5, 2025

i think the DialContext should do an eth_chainId call and set the response for its chain id. that would simplify a lot of things

@ddomeke
Copy link
Collaborator Author

ddomeke commented Nov 5, 2025

i think the DialContext should do an eth_chainId call and set the response for its chain id. that would simplify a lot of things

first version was doing that call, but rpc returned errors. So I changed it to this structure because the ethclient wrapper logic using this kind of function like "SetRetryInterval, SetMetricsHandler".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aomerk aomerk Awaiting requested review from aomerk

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ddomeke @aomerk