fix: use the new configuredFor method in all places
#5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A know bug is that when you have another ALTERNATIVE configured execution, the email OTP will always show in the list of "other ways" to login. It will not execute or be required, but it will be shown. This is because internal keycloak classes use the "normal" `configuredFor` method which does not take into consideration the flow configuration. These uses were spotted in (✅ means fixed, either in this pr or in main & ❌ means not yet fixed): - ✅ https://github.com/keycloak/keycloak/blob/579b185e7af60d741c97a1c73e975506b0c1e56c/services/src/main/java/org/keycloak/authentication/authenticators/conditional/ConditionalUserConfiguredAuthenticator.java#L61 - ✅ https://github.com/keycloak/keycloak/blob/579b185e7af60d741c97a1c73e975506b0c1e56c/services/src/main/java/org/keycloak/forms/login/freemarker/AuthenticatorConfiguredMethod.java#L46 - ❌ https://github.com/keycloak/keycloak/blob/579b185e7af60d741c97a1c73e975506b0c1e56c/services/src/main/java/org/keycloak/authentication/DefaultAuthenticationFlow.java#L458 - ❌ https://github.com/keycloak/keycloak/blob/579b185e7af60d741c97a1c73e975506b0c1e56c/services/src/main/java/org/keycloak/authentication/FormAuthenticationFlow.java#L197
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A know bug is that when you have another ALTERNATIVE configured execution, the email OTP will always show in the list of "other ways" to login. It will not execute or be required, but it will be shown.
This is because internal keycloak classes use the "normal"
configuredFormethod which does not take into consideration the flow configuration.These uses were spotted in (✅ means fixed, either in this pr or in main & ❌ means not yet fixed):