Feature/add list virtual machine sizes functionalities

[KevinLoiseau]

Hi !

This PR implement the virtual machine size's listing, through request and model.

Thanks in advance for your time

[maham-nazir-confiz]

Hello @KevinLoiseau
I will be reviewing and testing this PR. I will merge it if it passes all checks. It might take me some time. Thank you for your patience.

[maham-nazir-confiz]

Hi @KevinLoiseau

I have reviewed your PR. The following changes are requested

• Incorporate HoundCI feedback if possible.
• Add the memory_in_mb attribute in the virtual_machine_size model as well.
• Incorporate the feedback I have added in the code.

Thank you.
Regards

[KevinLoiseau]

Hi @maham-nazir-confiz

Thank you for your feedbacks, especially for memory_in_mb, thanks for catching this.
Your feedbacks are implemented.

Regards,
Kevin Loiseau

[maham-nazir-confiz]

@KevinLoiseau
Thank you for incorporating my feedback. I have a couple more changes to ask of you.

• Please write an integration test for this as well
• Can you tell me how did you test the list method with async = true? Because if you change async to true and then call the list method via the collection::all method, it throws the following exception
  Integration Test for virtual machine is failing! #<NoMethodError: undefined method 'map' for #<Concurrent::Promise:0x0055a658124bd0>>
  Please get back to me on this

Regards

[KevinLoiseau]

@maham-nazir-confiz I added an integration test for this part.
For your question about async = true, I tested it directly through the request because through the collection::all that could not works as the response object class is Concurrent::Promise and doesn't respond to map.
For the test; I called the request list_virtual_machine_sizes with async = true, i get an object Concurrent::Promise that is, after few instant, completed with the expected values (the list of virtual machine sizes).

Regards

[maham-nazir-confiz]

@KevinLoiseau
If you look at all the list methods that we have in fog-azure-rm you'll see that we have not used the async attribute because they all need to be parsed by the Collection::all method into their respective models.

You should update the PR to not use the async attribute at all and also use the list_as_lazy method as we have used in all the list request methods.

Regards,
Maham Nazir

[KevinLoiseau]

@maham-nazir-confiz
list_as_lazy is not implemented for virtual_machine_sizes (as the result list is finit on provider side, it's not a problem to provide by default all assets).

For the async call, I agree that we can't use it in Collection::all, but as it's implemented by Azure IMHO it's better to have it in the request part, the model stack will just not implement it by this way, it's not a problem.

If you really want I can remove the async call, but I don't think that is an added value for the project. WDYT ?

Regards,
Kevin