Skip to content

Validate full image name passed in for '--init-image' #433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Validate full image name passed in for '--init-image' #433

wants to merge 1 commit into from

Conversation

JadeRedworth
Copy link
Contributor

@JadeRedworth JadeRedworth requested a review from mjg123 September 25, 2018 10:32
@JadeRedworth JadeRedworth force-pushed the init-image-name-fix branch 2 times, most recently from 836b8cf to 6b035dc Compare September 25, 2018 12:56
@riconnon riconnon self-requested a review September 26, 2018 14:42
riconnon
riconnon suggested changes Sep 26, 2018
View reviewed changes
Copy link
Contributor

@riconnon riconnon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this broke the init-image test. I assume the test is failing the validation.
However, we should also add a test which deliberately uses an invalid image and checks for the expected error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjg123 mjg123 Awaiting requested review from mjg123

1 more reviewer

@riconnon riconnon riconnon requested changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JadeRedworth @riconnon