New Shielding Geometries Added in #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added in the new shielding geometry. Two new models have been added. 'Basic Lab', and 'Lab with Improved Shield'. Basic Lab includes the support frame, Anti-Radon Tent and Magnetic coil, 'Lab with Improved Shield' shield includes these and the iron and polyethylene shields.
I have had to redefine the module_0 object to accurately include the magnetic coil. This has created other problems as follows:
Selecting 'basic_iron' shield will now include the magnetic coil. This is obviously not consistent with the previous versions of falaise. I have tried to change this but am not sure the best way to proceed so for now have left it like this.
When I perform flsimulate with a magnetic field there is a clash:
flsimulate : Setup/run of simulation threw exception
[void mctools::g4::detector_construction::_construct_electromagnetic_field():704: Missing G4 logical volume with name 'module_basic.model.log' !]
(this does not affect the neutron simulations I have been performing but when others wish to use the new geometry to simulate events with a magnetic field there will be a problem). I am also not sure how to fix this so have left it like this and noted the problem.