Listen for GUI close #81
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This serves both to allow plugins to more easily detect when their GUIs are closed, and also to ensure that click listeners are unregistered and slot actions are removed to prevent memory leaks. Unless I'm mistaken, there's still a listener registered for each GUI opened, as well as a bunch of slot actions stored in memory. While these should now be cleared up when the player sends a close inventory packet, theoretically a malicious player could use a modded client to not send close packets and spam open a bunch of GUIs. This would register a bunch of listeners and store a bunch of click actions and GUIs in memory, potentially crashing the server. That is purely theoretical though, I don't know if that would actually work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This serves both to allow plugins to more easily detect when their GUIs are closed, and also to ensure that click listeners are unregistered and slot actions are removed to prevent memory leaks.
Unless I'm mistaken, there's still a listener registered for each GUI opened, as well as a bunch of slot actions stored in memory. While these should now be cleared up when the player sends a close inventory packet, theoretically a malicious player could use a modded client to not send close packets and spam open a bunch of GUIs. This would register a bunch of listeners and store a bunch of click actions and GUIs in memory, potentially crashing the server.
That is purely theoretical though, I don't know if that would actually work.