Skip to content

fix: honor event webhook timeout #1797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

steved
Copy link

@steved steved commented Apr 10, 2025

I can't find any specific evidence for it being hardcoded (38dfda9).

Signed-off-by: Steven Davidovitz <[email protected]>
@steved steved force-pushed the steved/event-webhook-timeout branch from 04ffb9c to a47d7b8 Compare April 10, 2025 18:38
@steved steved changed the title Steved/event webhook timeout honor event webhook timeouts Apr 10, 2025
@steved steved changed the title honor event webhook timeouts fix: honor event webhook timeout Apr 10, 2025
Copy link
Member

@aryan9600 aryan9600 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @steved! 🎖️

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.44%. Comparing base (12ee6cb) to head (a47d7b8).
Report is 23 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1797       +/-   ##
===========================================
- Coverage   39.44%   28.44%   -11.00%     
===========================================
  Files         287      287               
  Lines       22706    22802       +96     
===========================================
- Hits         8956     6487     -2469     
- Misses      12777    15594     +2817     
+ Partials      973      721      -252     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants