-
Notifications
You must be signed in to change notification settings - Fork 3.2k
[pigeon] Adds Kotlin lint tests to example code and fix lints #9034
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Can we add the lint that found this to the Pigeon test harness plugin's example app? |
@@ -65,7 +65,7 @@ android { | |||
} | |||
|
|||
dependencies { | |||
testImplementation 'junit:junit:4.+' | |||
testImplementation 'junit:junit:4.13.2' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fixes the GradleDynamicVersion lint.
@tarrinneal @stuartmorgan-g I could only get |
Fixes flutter/flutter#166780
Pre-Review Checklist
[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3