Skip to content

[pigeon] Adds Kotlin lint tests to example code and fix lints #9034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 21 commits into
base: main
Choose a base branch
from

Conversation

bparrishMines
Copy link
Contributor

@bparrishMines bparrishMines commented Apr 9, 2025

Fixes flutter/flutter#166780

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2 3

@bparrishMines bparrishMines changed the title Pigeon im lints [pigeon] Fixes Kotlin InstanceManager not properly removing callbacks from handler Apr 9, 2025
@stuartmorgan-g
Copy link
Contributor

Can we add the lint that found this to the Pigeon test harness plugin's example app?

@bparrishMines bparrishMines marked this pull request as ready for review April 15, 2025 18:48
@github-actions github-actions bot added the p: interactive_media_ads Plugin for IMA SDK label Apr 15, 2025
@github-actions github-actions bot removed the p: interactive_media_ads Plugin for IMA SDK label Apr 15, 2025
@bparrishMines bparrishMines changed the title [pigeon] Fixes Kotlin InstanceManager not properly removing callbacks from handler [pigeon] Add Kotlin lint tests to example code and fix lints Apr 16, 2025
@bparrishMines bparrishMines changed the title [pigeon] Add Kotlin lint tests to example code and fix lints [pigeon] Adds Kotlin lint tests to example code and fix lints Apr 16, 2025
@@ -65,7 +65,7 @@ android {
}

dependencies {
testImplementation 'junit:junit:4.+'
testImplementation 'junit:junit:4.13.2'
Copy link
Contributor Author

@bparrishMines bparrishMines Apr 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the GradleDynamicVersion lint.

@bparrishMines
Copy link
Contributor Author

@tarrinneal @stuartmorgan-g I could only get ImplicitSamInstance lint to fail on ./gradlew lint but not on build. I updated the custom tests of the plugin to run lint on test_plugin. It seems that ImplicitSamInstance is already included, but calling handler.removeCallbacks { this.releaseAllFinalizedInstances() } doesn't seem to trigger it. But calling handler.removeCallbacks(::releaseAllFinalizedInstances) does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[pigeon] Kotlin InstanceManager doesn't properly remove callbacks from handler
3 participants