Skip to content

Conversation

@okorohelijah
Copy link
Contributor

@okorohelijah okorohelijah commented Oct 30, 2025

In preparation of upgrading our fleet to macOS 15.7, allow tests to run on either macOS 15.5 or 15.7.

List which issues are fixed by this PR. You must list at least one issue.
Fixes flutter/flutter#176931

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2 3

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the CI configuration to run tests on macOS 15.5 or 15.7, replacing the previous configuration that targeted macOS 14 and 15.5. My review suggests that during this transition, it might be safer to temporarily continue testing on macOS 14 to prevent any potential regressions. I've added comments with suggestions to include all three versions in the test matrix for both arm64 and x86 architectures.

{"dependency": "ruby", "version": "ruby_3.1-pod_1.13"}
]
os: Mac-14|Mac-15.5
os: Mac-15.5|Mac-15.7

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This change removes Mac-14 from the list of test platforms for arm64. To prevent potential regressions on Mac-14 during the transition to Mac-15.7, it would be safer to test against all three versions temporarily.

      os: Mac-14|Mac-15.5|Mac-15.7

{"dependency": "ruby", "version": "ruby_3.1-pod_1.13"}
]
os: Mac-14|Mac-15.5
os: Mac-15.5|Mac-15.7

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This change removes Mac-14 from the list of test platforms for x86. To prevent potential regressions on Mac-14 during the transition to Mac-15.7, it would be safer to test against all three versions temporarily.

      os: Mac-14|Mac-15.5|Mac-15.7

@vashworth
Copy link
Contributor

@okorohelijah Why was this closed?

@okorohelijah
Copy link
Contributor Author

@vashworth nit: i created the pr directly from my main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update .ci.yaml in flutter/packages to use either macOS 15.5 or macOS 15.7.1

2 participants