[camera_avfoundation] Wrappers swift migration - part 3 #10293
Conversation
RobertOdrowaz
requested review from
hellohuanlin and
vashworth
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request migrates FLTCaptureDevice, FLTCaptureSession, and FLTFormatUtils classes to Swift, removing the FLT prefixes and replacing Default class implementations with protocol conformance on base AV classes. The changes include modifications to the example project and the core implementation, updating tests and adapting to the new Swift conventions. The review focuses on ensuring correctness, maintainability, and adherence to the project's coding standards.
packages/camera/camera_avfoundation/example/ios/RunnerTests/CameraSessionPresetsTests.swift
Show resolved
Hide resolved
packages/camera/camera_avfoundation/example/ios/RunnerTests/CameraSessionPresetsTests.swift
Show resolved
Hide resolved
packages/camera/camera_avfoundation/example/ios/RunnerTests/CameraSettingsTests.swift
Show resolved
Hide resolved
packages/camera/camera_avfoundation/example/ios/RunnerTests/CameraSettingsTests.swift
Show resolved
Hide resolved
packages/camera/camera_avfoundation/example/ios/RunnerTests/CameraSettingsTests.swift
Show resolved
Hide resolved
packages/camera/camera_avfoundation/example/ios/RunnerTests/SampleBufferTests.swift
Show resolved
Hide resolved
packages/camera/camera_avfoundation/example/ios/RunnerTests/SampleBufferTests.swift
Show resolved
Hide resolved
packages/camera/camera_avfoundation/example/ios/RunnerTests/SampleBufferTests.swift
Show resolved
Hide resolved
packages/camera/camera_avfoundation/example/ios/RunnerTests/SampleBufferTests.swift
Show resolved
Hide resolved
.../camera_avfoundation/ios/camera_avfoundation/Sources/camera_avfoundation/DefaultCamera.swift
Show resolved
Hide resolved
|
Hi, could you sweep through gemini's comment first? |
|
@hellohuanlin done, there was nothing meaningful there, a bunch of comments regarding argument names in mocks and some streight up invalid suggestions |
RobertOdrowaz
force-pushed
the
feature/camera-wrappers-swift-migration-part3
branch
from
49ed2ce to
b67ac9d
Compare
|
@hellohuanlin pls take a look at this PR again when you have some time |
| let camera = CameraTestUtils.createTestCamera(configuration) | ||
|
|
||
| let range = camera.captureDevice.activeFormat.videoSupportedFrameRateRanges[0] | ||
| let range = camera.captureDevice.fltActiveFormat.videoSupportedFrameRateRanges[0] |
There was a problem hiding this comment.
why are we renaming it?
| var deviceType = AVCaptureDevice.DeviceType.builtInWideAngleCamera | ||
|
|
||
| var activeFormat: FLTCaptureDeviceFormat { | ||
| var fltActiveFormat: FLTCaptureDeviceFormat { |
There was a problem hiding this comment.
is FLTCaptureDeviceFormat still in ObjC or is it migrated to Swift?
|
|
||
| /// Determines the video dimensions (width and height) for a given capture device format. | ||
| /// Used in tests to mock CMVideoFormatDescriptionGetDimensions. | ||
| typealias VideoDimensionsForFormat = (FLTCaptureDeviceFormat) -> CMVideoDimensions |
There was a problem hiding this comment.
can you rename it to VideoDimensionsConverter per our previous discussion
| /// Preferred are formats with the same subtype as current activeFormat. Sets this format | ||
| /// as activeFormat and also updates mediaSettings.framesPerSecond to value which | ||
| /// bestFrameRate returned for that format. | ||
| func selectBestFormat( |
There was a problem hiding this comment.
can we put these 2 helper funcs under a namespace (e.g. enum) so it doesn't pollute the global namespace
3 participants
Migrates camera wrappers as part of flutter/flutter#119109
This PR migrates wrappers to Swift:
FLTCaptureDeviceFLTCaptureSessionFLTFormatUtilsIn line with Swift conventions, the
FLTprefixes are removed. TheDefaultclass implementations are replaced with protocol conformance on baseAVclasses.Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3