Skip to content

[go_router] Migrates test for leak testing #10276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 6, 2025
+32 −24
Merged

[go_router] Migrates test for leak testing #10276

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fe8f0fe
Migrates test
hgraceb Oct 22, 2025
c73a2b5
Improve test
hgraceb Oct 23, 2025
8471c5f
Improve test
hgraceb Oct 23, 2025
f0e6f83
Improve test
hgraceb Oct 23, 2025
54243e8
Merge branch 'main' into go_router
chunhtai Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 32 additions & 24 deletions packages/go_router/test/extra_codec_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import 'dart:convert';
import 'package:flutter/material.dart';
import 'package:flutter_test/flutter_test.dart';
import 'package:go_router/go_router.dart';
import 'package:leak_tracker_flutter_testing/leak_tracker_flutter_testing.dart';

import 'test_helpers.dart';

Expand Down Expand Up @@ -52,33 +53,40 @@ void main() {
expect(find.text(initialString), findsOneWidget);
});

testWidgets('Restores state correctly', (WidgetTester tester) async {
const String initialString = 'some string';
const String empty = 'empty';
final List<RouteBase> routes = <RouteBase>[
GoRoute(
path: '/',
builder: (_, GoRouterState state) {
return Text((state.extra as ComplexData?)?.data ?? empty);
},
),
];
testWidgets(
'Restores state correctly',
(WidgetTester tester) async {
const String initialString = 'some string';
const String empty = 'empty';
final List<RouteBase> routes = <RouteBase>[
GoRoute(
path: '/',
builder: (_, GoRouterState state) {
return Text((state.extra as ComplexData?)?.data ?? empty);
},
),
];

await createRouter(
routes,
tester,
initialExtra: ComplexData(initialString),
restorationScopeId: 'test',
extraCodec: ComplexDataCodec(),
);
expect(find.text(initialString), findsOneWidget);
await createRouter(
routes,
tester,
initialExtra: ComplexData(initialString),
restorationScopeId: 'test',
extraCodec: ComplexDataCodec(),
);
expect(find.text(initialString), findsOneWidget);

await tester.restartAndRestore();
addTearDown(tester.binding.restorationManager.dispose);
await tester.restartAndRestore();

await tester.pumpAndSettle();
expect(find.text(initialString), findsOneWidget);
});
await tester.pumpAndSettle();
expect(find.text(initialString), findsOneWidget);
},
// TODO(hgraceb): Remove when minimum flutter version includes
// https://github.com/flutter/flutter/pull/176519
experimentalLeakTesting: LeakTesting.settings.withIgnored(
classes: const <String>['TestRestorationManager', 'RestorationBucket'],
),
);
}

class ComplexData {
Expand Down